More perf improvements#638
Merged
Merged
Conversation
The string is typically shared across all variables in a dataset, so parse once per distinct attr. Wrap the cached result in `Frozen` to prevent accidental mutation of the shared value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Skip the per-key _get_all fan-out when every key is already a plain data-variable name — the slow path would just fall through to the same result. Decoration via get_associated_variable_names is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
drop_bounds is a no-op unless the caller passed a scalar key, so list-key calls (ds.cf[[name]]) never need it. Inline the lookup so list-key paths skip the full-dataset bounds scan entirely. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dcherian
force-pushed
the
perf-getitem-hot-path
branch
from
76a9b84 to
8457375
Compare
dcherian
commented
May 12, 2026
| varnames = list(key_iter) | ||
| coords = [] | ||
| successful = dict.fromkeys(key_iter, True) | ||
| else: |
dcherian
force-pushed
the
perf-getitem-hot-path
branch
from
234a065 to
e5291c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.